[Webkit-unassigned] [Bug 115266] RenderMeter::valueRatio() is private

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 26 11:13:21 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115266





--- Comment #2 from Jesus Sanchez-Palencia <jesus at webkit.org>  2013-04-26 11:11:42 PST ---
(From update of attachment 199845)
View in context: https://bugs.webkit.org/attachment.cgi?id=199845&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests.

You should specify the reason why no new tests were needed (e.g.: "No new tests, no behavior was changed").

> Source/WebCore/rendering/RenderMeter.h:41
> +    double valueRatio() const;

Why do you need it to public? A 1-line explanation in Changelog should be enough. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list