[Webkit-unassigned] [Bug 115142] Permit ~/Library to be a symlink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115142





--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2013-04-25 09:43:18 PST ---
(From update of attachment 199570)
View in context: https://bugs.webkit.org/attachment.cgi?id=199570&action=review

Looks good to me, with a question about pwd.pw_dir encoding below.

Note however that this behavior doesn't quite match AppSandbox, which also allows ~/Library/Preferences to be a symlink.

> Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:18
> +(define (home-library-regex home-library-relative-regex)
> +  (regex (string-append "^" (regex-quote (param "HOME_LIBRARY_DIR")) home-library-relative-regex)))

Indentation should be 4 characters here, too.

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:142
> +    String libraryPath = String(pwd.pw_dir);

This constructor treats the input as Latin-1. Is this correct, or should it be UTF-8? In the latter case, String::fromUTF8() is the right way to create the String object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.