[Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103771





--- Comment #29 from Sebastian Dröge <slomo at circular-chaos.org>  2013-04-25 08:38:02 PST ---
(In reply to comment #27)
> (In reply to comment #23)
> > What you describe here is exactly what should be inside playbin and exposed via some new API on playbin (and the second item is actually implemented already, and not only for video but audio and text too).
> 
> The thing that makes me want to not use playbin is that we need to handle every stream differently, and that seems to not mesh well with using playbin. For video, we want an inputselector, which playbin provides, but for audio we want an adder, and for text we just want all of the pads exposed. It seems like playbin is a one-size-fits-all solution, and that's not really what we need.

If you were able to set a N->1 stream combiner element for audio, video and text you would be able to handle all these cases just fine in playbin without losing the comfort of all the other playbin features.

> > playbin is using uridecodebin and playsink internally, and lots of glue to make them both work perfectly together. The latter is what would have to be reimplemented if you stop using playbin.
> 
> I haven't got to video yet, but don't I just need to take any pad I see in pad-added and add it to the video inputselector? The glue I have so far is just handling padAdded() and connecting audio and video to a playsink, and connecting text to a queue then appsink. Ignoring callbacks and other things that I would need anyway, it's only about 40 lines of code, and using uridecodebin makes other parts of the code simpler, since pad-added and pad-removed are easier to work with than text-changed.

Take a look at the playbin code and you'll see that there's much more involved :)

(In reply to comment #28)
> One more question: Is there a way to figure out the track "kind" in GStreamer? Should there be a GST_TAG_KIND?

What do you mean with kind? If it's audio/video/text? Look at gstplaybin2.c, the code that checks to which input-selector a pad of uridecodebin belongs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.