[Webkit-unassigned] [Bug 114960] Wrong text position when you click backspace on the line below the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114960





--- Comment #7 from Lukasz Gajowy <l.gajowy at samsung.com>  2013-04-25 08:10:13 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Changing m_upstreamStart to m_upstreamEnd in:
> > 
> > https://trac.webkit.org/browser/trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp#L607
> > 
> > fixes this issue. What do you think of this solution?
> 
> That doesn't sound like a good solution without a more detailed description as to why that's the right fix.

As i was debugging the code I assumed that m_upstreamEnd is the Position of the end of an image (according to the test page included). I came up to a conclusion, that the merge destination should be set to the m_upstreamEnd, because when we hit backspace, we want to have the text at the end of the image, not at the start of it. I am not sure that I understand 
this code well. Please correct me if I am wrong.

Another thesis is that the problem stems from wrong behaviour of mergeParagraphs() method, when in m_upstreamStart field (it is a Position class object):
 - m_offset = 0
 - m_anchorNode = 2 (AnchorType = PositionIsAfterAnchor)

What do you think of that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.