[Webkit-unassigned] [Bug 114809] [WK2][GTK] ExceededDatabaseQuota method/signal support in WebKitUIClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114809





--- Comment #11 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2013-04-25 07:14:39 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > (From update of attachment 199326 [details] [details] [details])
> > > Perhaps I'm misreading your patch, but it seems you set can adjust the default database quota in WebKitSettings, but that it isn't used at all.
> > 
> > It's used on webkitWebViewExceededDatabaseQuotaPermissionRequest.
> 
> Ah, thanks!
> 
> > But forget about this patch for now, I'm assuming that the default value starts with 0.
> > What's the best way to initiate a value on WebkitSettingsPrivate now that it's being constructed automatically?
> 
> I think a good first patch for this API is to skip the signal for now and simply use the value that the API consumer sets on WebKitSettings. Perhaps Carlos has a different opinion, but we are trying to avoid the overwhelming amount of signals that we had in WebKit1.

Is there an alternative way to warn the user that an origin is over-using its database quota without using the webview signal? I agree with your concerns about the overwhelming amount of signals on webkit1, but does it pay the cost of removing a feature to keep the signal list clear?

Carlos, would you mind to give your opinion/suggestion in this case, please?

Anyway, since the WebkitSettings setter/getter is enough to allow the sqldatabase usage, I'm adapting the patch to include/use only that part and we can keep the signal discussion for later. Are you OK with that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.