[Webkit-unassigned] [Bug 115138] [QNX][ARM] Use hardware integer division where available

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115138


Cosmin Truta <ctruta at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #199537|0                           |1
        is obsolete|                            |
 Attachment #199607|                            |review?, commit-queue?
               Flag|                            |




--- Comment #4 from Cosmin Truta <ctruta at gmail.com>  2013-04-24 19:13:44 PST ---
Created an attachment (id=199607)
 --> (https://bugs.webkit.org/attachment.cgi?id=199607&action=review)
Patch

(In reply to comment #3)
> What you should do is:
>     -MacroAssembler::supportsIntegerDiv() is a _compile time_ constant for everything but QNX
>     [...]

Done. This allowed me to simplify preprocessor conditionals in other places, and rely on the fact that this gets resolved at compile time whenever possible.

> That makes no sense. What if you  are ArithDiv and MacroAssembler::supportsIntegerDiv() evaluate to false, you just silently ignore the operation?

>From what I understood so far, the call site is responsible not to branch here if IDIV isn't available, hence the RELEASE_ASSERT_NOT_REACHED further below. And you're right, that if-statement shouldn't be there. I changed it into an assertion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.