[Webkit-unassigned] [Bug 115118] [GTK] Use stamp files for generate-forwarding-headers makefile rules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115118





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-04-24 11:12:38 PST ---
(From update of attachment 199499)
View in context: https://bugs.webkit.org/attachment.cgi?id=199499&action=review

Looks good. I just have one question...

> Source/WebKit2/GNUmakefile.am:326
>  BUILT_SOURCES += generate-webkit2-forwarding-headers

Would it make more sense to add the stamp files to BUILT_SOURCES now?

> Tools/TestWebKitAPI/GNUmakefile.am:229
> +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES)

I don't think there's any need for this intermediate variable, unless it's used somewhere else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.