[Webkit-unassigned] [Bug 114809] [WK2][GTK] ExceededDatabaseQuota method/signal support in WebKitUIClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 23 15:16:47 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114809





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2013-04-23 15:15:05 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 199326 [details] [details])
> > Perhaps I'm misreading your patch, but it seems you set can adjust the default database quota in WebKitSettings, but that it isn't used at all.
> 
> It's used on webkitWebViewExceededDatabaseQuotaPermissionRequest.

Ah, thanks!

> But forget about this patch for now, I'm assuming that the default value starts with 0.
> What's the best way to initiate a value on WebkitSettingsPrivate now that it's being constructed automatically?

I think a good first patch for this API is to skip the signal for now and simply use the value that the API consumer sets on WebKitSettings. Perhaps Carlos has a different opinion, but we are trying to avoid the overwhelming amount of signals that we had in WebKit1.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list