[Webkit-unassigned] [Bug 115029] [BlackBerry] Simplify BackForwardListBlackBerry::clear

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115029





--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2013-04-23 05:17:46 PST ---
(In reply to comment #2)
> > Source/WebKit/blackberry/WebCoreSupport/BackForwardListBlackBerry.cpp:106
> > -    while (!m_impl->entries().isEmpty())
> > -        m_impl->removeItem(m_impl->entries().last().get());
> > +    m_impl->setCapacity(0);
> 
> I'm not sure it's the same, removeItem doesn't change the capacity and setCapacity also removes the items from the page cache.

About the capacity: you are right, the patch is even wrong. What is needed is set it to zero to clear it up and then re-set to the previous capacity (so in the end it won't be changed).

Not sure about the page cache, we can look into it, but fwiw other ports clear the bf list in a similar way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.