[Webkit-unassigned] [Bug 114892] [BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114892


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198919|review?                     |review-
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2013-04-22 08:05:51 PST ---
(From update of attachment 198919)
View in context: https://bugs.webkit.org/attachment.cgi?id=198919&action=review

LGTM.

> Source/WebKit/blackberry/WebCoreSupport/BatteryClientBlackBerry.cpp:40
> +    m_isActive = true;

You can group these, no need to set m_isActive to true if you already know it is true.

> Source/WebKit/blackberry/WebCoreSupport/BatteryClientBlackBerry.cpp:47
> +    m_isActive = false;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.