[Webkit-unassigned] [Bug 114894] New: RenderText::computePreferredLogicalWidths use of isBreakable() is inefficient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114894

           Summary: RenderText::computePreferredLogicalWidths use of
                    isBreakable() is inefficient
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: glenn at skynav.com
                CC: eric at webkit.org, mitz at webkit.org, ggaren at apple.com,
                    dino at apple.com, rniwa at webkit.org


RenderText::computePreferredLogicalWidths uses isBreakable() twice, each time ignoring the nextBreakable out parameter. Since isBreakable(), by mapping to nextBreakblePosition(), iterates forward to the next break point rather than simply determining if the specified position is breakable, it performs unneeded and unused computation, e.g., by repeatedly calling textBreakFollowing() which maps (on ICU platforms) to ubrk_following().

I propose a variant of isBreakable() that doesn't take a nextBreakable parameter be used in these two cases in computePreferredLogicalWidths, which would use a simplified form of nextBreakablePosition that only checks if the specified position is breakable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.