[Webkit-unassigned] [Bug 18092] table's text aligned on top instead of center because of rowspan

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18092


Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198726|review?                     |review-
               Flag|                            |




--- Comment #8 from Beth Dakin <bdakin at apple.com>  2013-04-19 16:16:57 PST ---
(From update of attachment 198726)
View in context: https://bugs.webkit.org/attachment.cgi?id=198726&action=review

Ultimately, I find this patch a little confusing right now. I would like to see another pass with clearer comments.

> Source/WebCore/ChangeLog:9
> +        then rowspan height is not applied to last row.

This description is very confusing. Please find a more clear way to say this.

> Source/WebCore/rendering/RenderTableSection.cpp:303
> +                    // than 'rows below rowspan cell + 1'

Just like I said in the Changelog, this description is very confusing. Please find a more clear way to say this.

> Source/WebCore/rendering/RenderTableSection.cpp:308
> +                        while (nextRowCell.cells.size() && nextRowCell.cells[0]->rowSpan() > 1 && nextRowCell.cells[0]->rowIndex() < (r + 1)) {

The code would be more clear if you added a comment. Based on your description in the bug, you are trying to deterring if there is a valid next row, correct? Please say something like that here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.