[Webkit-unassigned] [Bug 114809] [WK2][GTK] ExceededDatabaseQuota method/signal support in WebKitUIClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114809


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198898|review?                     |review-
               Flag|                            |




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2013-04-19 11:33:42 PST ---
(From update of attachment 198898)
View in context: https://bugs.webkit.org/attachment.cgi?id=198898&action=review

The signal is per-WebView, but the setting you are adding is per WebContext. I think this might be a better candidate for a WebSetting (applies to all WebViews in a WebViewGroup) or something more fine-grained. Having a setting on the WebContext does not allow you to create WebViews with different quotas.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:200
> +                                                     guint64                       *defaultQuota);

You should use default_quota here, defaultQuota in the C++ implementation file, and default_quota for the documentation.

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1356
>> +                     G_TYPE_UINT64);
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

You can ensure your code passes the style bot by uploading your patches with webkit-patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.