[Webkit-unassigned] [Bug 113284] [EFL] Add method in ewk_settings for setting the CSS media type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 19 03:53:54 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113284


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dchris at gmail.com




--- Comment #24 from Christophe Dumez <dchris at gmail.com>  2013-04-19 03:52:11 PST ---
(In reply to comment #23)
> (In reply to comment #22)
> > null -> @c NULL
> Corrected.
> 
> > Are you working for Samsung?
> I work for Cisco. Earlier was with Samsung :) I will update this.
> 
> > > Source/WebKit/efl/tests/test_ewk_setting.cpp:38
> > > +{
> > 
> > Please check the default value ("screen") of ewk_settings_css_media_type_get().
> 
> Please see doc of ewk_settings_css_media_type_get(). (It will only return the value set through ewk_settings_css_media_type_set and not the one used internally. So if nothing is set, it will return null. I have updated documentation of ewk_settings_css_media_type_set now to avoid confusion.)

Either way, you need to test the default value in the unit test, it being NULL or "screen".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list