[Webkit-unassigned] [Bug 113284] [EFL] Add method in ewk_settings for setting the CSS media type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113284





--- Comment #22 from Christophe Dumez <dchris at gmail.com>  2013-04-19 02:56:30 PST ---
(From update of attachment 198833)
View in context: https://bugs.webkit.org/attachment.cgi?id=198833&action=review

> Source/WebKit/efl/ewk/ewk_settings.h:394
> + * Setting the value to null will restore the default value.

null -> @c NULL

> Source/WebKit/efl/tests/test_ewk_setting.cpp:2
> + * Copyright (C) 2013 Samsung Electronics

Are you working for Samsung?

> Source/WebKit/efl/tests/test_ewk_setting.cpp:38
> +{

Please check the default value ("screen") of ewk_settings_css_media_type_get().

> Source/WebKit/efl/tests/test_ewk_setting.cpp:39
> +    ewk_settings_css_media_type_set("screen");

Since this is the default value, you should probably set something else than "screen" first, to make sure it works.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:40
> +    ASSERT_EQ(strcmp(ewk_settings_css_media_type_get(), "screen"), 0);

We usually use ASSERT_STREQ() for string comparisons.

> Source/WebKit/efl/tests/test_ewk_setting.cpp:47
> +}

Please check resetting the default value by passing NULL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.