[Webkit-unassigned] [Bug 83681] [GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83681


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198735|review?                     |review+
               Flag|                            |




--- Comment #19 from Anders Carlsson <andersca at apple.com>  2013-04-18 08:52:27 PST ---
(From update of attachment 198735)
View in context: https://bugs.webkit.org/attachment.cgi?id=198735&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:140
> +    WebURLRequest* newRequest = WebURLRequest::create(webkitURIRequestGetResourceRequest(request.get())).leakRef();

I think you should put this in a RefPtr instead if calling leakRef() here.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:150
> +    return toAPI(newRequest);

Then you can call release().leakRef() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.