[Webkit-unassigned] [Bug 112327] Reorganize animation starting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112327


Nandor Huszka <hnandor at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193086|0                           |1
        is obsolete|                            |
 Attachment #197232|0                           |1
        is obsolete|                            |




--- Comment #11 from Nandor Huszka <hnandor at inf.u-szeged.hu>  2013-04-17 01:26:30 PST ---
Created an attachment (id=198478)
 --> (https://bugs.webkit.org/attachment.cgi?id=198478&action=review)
WIP patch v3 - Approach: animations are started by FrameView 

(In reply to comment #10)
> Please note r148300 just landed for bug 108864. It changes how gif animations are restarted after having been suspended.
I've checked this patch, and reused its solution, thanks.

With the freshest WIP patch there are about 10 crashes on Qt because of ASSERT(frame()->view());
It seems in some cases there isn't a FrameView under this reference when a RenderObject is dying.
Maybe AnimationController::cancelAnimations would be the correct place for deleting dying animations from FrameView?
It is called also in RenderObject::willBeDestroyed.

FYI: a mail will be sent to webkit-dev about it with subject "Reorganization of animation starting".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.