[Webkit-unassigned] [Bug 102932] [EFL][WK2] Implement context menu in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102932





--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-04-16 17:28:31 PST ---
(From update of attachment 198392)
View in context: https://bugs.webkit.org/attachment.cgi?id=198392&action=review

> Tools/MiniBrowser/efl/main.c:1107
> +

Unneeded line.

> Tools/MiniBrowser/efl/main.c:1123
> +fill_context_popup_items(Browser_Window *window, Ewk_Context_Menu *ewk_menu)

verb is placed at the end of function in EFL coding style. See also, popup_menu_populate(...) in main.cp

> Tools/MiniBrowser/efl/main.c:1157
> +    if (!window || !menu)

It would be good if you add a log using info(...).

> Tools/MiniBrowser/efl/main.c:1178
> +    if (!window || !window->context_popup)

ditto ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.