[Webkit-unassigned] [Bug 114402] [CSS Exclusions] polygon shape-inside layout fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114402


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198388|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Dirk Schulze <krit at webkit.org>  2013-04-16 15:23:47 PST ---
(From update of attachment 198388)
View in context: https://bugs.webkit.org/attachment.cgi?id=198388&action=review

r=me. Just some editorial change requests.

> Source/WebCore/ChangeLog:18
> +        (WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Avoid floating point problems when checking intersections with the offset edge based on minLogicalIntervalTop.

Split the comment into two lines.

> Source/WebCore/ChangeLog:21
> +        (WebCore::OffsetPolygonEdge::basis): Report what the offset edge is "based on": a polygon edge, the top of the line, or a (reflex) vertex.

Ditto.

> Source/WebCore/rendering/ExclusionPolygon.h:41
> +    enum Basis { Edge, Vertex, LineTop };

I'd like to have a new line for each enum item. This is usually used nowadays.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.