[Webkit-unassigned] [Bug 114674] [BlackBerry] LayerTexture: check if the graphics context is NULL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114674


Alberto Garcia <agarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198280|0                           |1
        is obsolete|                            |
 Attachment #198280|review?, commit-queue?      |
               Flag|                            |
 Attachment #198333|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Alberto Garcia <agarcia at igalia.com>  2013-04-16 08:44:43 PST ---
Created an attachment (id=198333)
 --> (https://bugs.webkit.org/attachment.cgi?id=198333&action=review)
Patch

(In reply to comment #2)
> > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:-70
> > -    gc->addFillRect(BlackBerry::Platform::FloatRect(0, 0, 1, 1));
> Why was this never a problem before? Did the semantics of
> lockBufferDrawable change?

They didn't, it can actually return a null pointer. I don't think it's
the case here anyway but see also bug 114005.

> > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:69
> > +    if (gc) {
> It is WebKit style to put the temp var declaration in the if.

Ok, fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.