[Webkit-unassigned] [Bug 114639] New: [CSS Shaders] Extract validation logic out of CustomFilterValidatedProgram into a CustomFilterValidator class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114639

           Summary: [CSS Shaders] Extract validation logic out of
                    CustomFilterValidatedProgram into a
                    CustomFilterValidator class
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mvujovic at adobe.com
                CC: michelangelo at webkit.org, achicu at adobe.com
            Blocks: 71392


Alex's comment:
"""
Let's extract the validation out of CustomFilterValidatedProgram into a separate class like CustomFilterValidator where we could store the mix/webgl shader validators and have all the blending code. CustomFilterValidatedProgram should only contain the "storing" logic, it is just the result of the CustomFilterValidator. I think we could consolidate that with CustomFilterProgram (which is the 'raw' program information).
"""

In addition, I don't think we need to keep around the validated shader strings after we have a compiled program.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.