[Webkit-unassigned] [Bug 113124] Add animation support for WebP images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113124





--- Comment #4 from noel gordon <noel.gordon at gmail.com>  2013-04-15 07:43:08 PST ---
(In reply to comment #3)
> @Noel and others:
> I believe that this patch is relevant to Chromium port only (looking at the TestExpectations etc); no other ports have 'USE(WEBP)' flag set. Is that correct?
> If so, I'll revert this after migration.

Other ports use webp and hence WEBPImageDecoder.{cpp,h}, but they won't get here (animation) until they upgrade their bots and builds to use libwebp 0.3.0.  Does that answer your question?

One thing I noticed with this patch: are you are creating m_demux once only from the input m_data->data()? That's gonna hurt if the demux maintains pointers into that m_data->data() with progressive decoding because the underlying data may be moved around (consolidated) on subsequent m_data->data() calls, bug 104302.  Any pointers to the original data may become invalid, meaning we'd crash on access.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.