[Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation setting to webkit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114298


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197306|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #16 from Gustavo Noronha (kov) <gns at gnome.org>  2013-04-15 06:52:24 PST ---
(From update of attachment 197306)
View in context: https://bugs.webkit.org/attachment.cgi?id=197306&action=review

Straight-forward API, looks good to me, cq- because of the wording in the doc

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1087
> +     * Whether to enable Spatial navigation. This feature consists in the ability

I'd use lower case for spatial here

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1091
> +     * there is an element he might be trying to reach towards the right, and if

s/he/they/

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1092
> +     * there are multiple elements, which element he probably wants.

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.