[Webkit-unassigned] [Bug 114468] color-index media feature not supported

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114468


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197730|review?                     |review+
               Flag|                            |




--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2013-04-12 07:38:10 PST ---
(From update of attachment 197730)
View in context: https://bugs.webkit.org/attachment.cgi?id=197730&action=review

> Source/WebCore/css/MediaQueryEvaluator.cpp:246
> +    if (value)
> +        return numberValue(value, number) && compareValue(0, static_cast<int>(number), op);
> +
> +    return false;

I would prefer 

if (!value)
    return

return number...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.