[Webkit-unassigned] [Bug 105451] Unable to place caret in RTL Override Characters by mouse click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105451





--- Comment #16 from Yi Shen <max.hong.shen at gmail.com>  2013-04-11 20:08:52 PST ---
Yes, WebKit does create a run consisting of exactly LF in that case. 

Regarding the ending white space characters, I totally agree that we should check this condition also. But before that, we have to rework the code to generate a run that only consists the ending white space in that case -- currently, the run that contains the ending white space also contain other characters, while we don't want to reset the embedding level for the non-space characters in that run. I would like to create another bug to address that issue :)
(In reply to comment #15)
> (From update of attachment 197684 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197684&action=review
> 
> > Source/WebCore/platform/text/BidiResolver.h:511
> > +        if (run && run->onlyHasNewlineCharacter()) {
> 
> According to L1, we need to reset the embedding level of "[a]ny sequence of white space characters at the end of the line" as well.
> Shouldn't we checking that condition instead? Or do we create a run consisting of exactly LF in that case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.