[Webkit-unassigned] [Bug 114412] Add platform support for -webkit-background-blend-mode to CG context with background color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114412


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197641|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2013-04-11 10:59:02 PST ---
(From update of attachment 197641)
View in context: https://bugs.webkit.org/attachment.cgi?id=197641&action=review

Is there measurable performance impact for the code paths that now do extra work for non-blend cases? I’m guessing no.

What does this do for graphics back ends other than CG?

> Source/WebCore/ChangeLog:16
> +        (GraphicsContext):

Would be nice to remove this bogus change log line and/or fix the script that added it.

> LayoutTests/css3/compositing/effect-background-blend-mode-color.html:5
> +  if (window.testRunner) {
> +    window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled", "1");
> +  }

Extra braces not needed here. Why test only in this mode? Don’t we want to test both modes?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.