[Webkit-unassigned] [Bug 114386] New: [webkitpy] SVNTest fails if using git svn rather than svn for local repository

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114386

           Summary: [webkitpy] SVNTest fails if using git svn rather than
                    svn for local repository
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: glenn at skynav.com
                CC: dpranke at chromium.org, rniwa at webkit.org,
                    benjamin at webkit.org


If the local repository is git based rather than svn based, then the following 4 tests fail when running test-webkitpy --all as follows. In each case, an attempt is being made to invoke 'svn' directly.

% test-webkitpy --all
Suppressing most webkitpy logging while running unit tests.

[128/1584] webkitpy.common.checkout.scm.scm_unittest.SVNTest.test_add_recursively erred:
  Traceback (most recent call last):
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 825, in test_add_recursively
      self._shared_test_add_recursively()
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 466, in _shared_test_add_recursively
      self.scm.add("added_dir/added_file")
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 134, in add
      self.add_list([path], return_exit_code)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 187, in add_list
      return self._run_svn(["add"] + paths, return_exit_code=return_exit_code)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 137, in _run_svn
      return self.run([self.executable_name] + args, **kwargs)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 78, in run
      decode_output=decode_output)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 432, in run_command
      (error_handler or self.default_error_handler)(script_error)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 350, in default_error_handler
      raise error
  ScriptError: Failed to run "['svn', 'add', 'added_dir/added_file']" exit_code: 1

[143/1584] webkitpy.common.checkout.scm.scm_unittest.SVNTest.test_delete_recursively erred:
  Traceback (most recent call last):
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 839, in test_delete_recursively
      self._shared_test_delete_recursively()
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 472, in _shared_test_delete_recursively
      self.scm.add("added_dir/added_file")
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 134, in add
      self.add_list([path], return_exit_code)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 187, in add_list
      return self._run_svn(["add"] + paths, return_exit_code=return_exit_code)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 137, in _run_svn
      return self.run([self.executable_name] + args, **kwargs)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 78, in run
      decode_output=decode_output)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 432, in run_command
      (error_handler or self.default_error_handler)(script_error)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 350, in default_error_handler
      raise error
  ScriptError: Failed to run "['svn', 'add', 'added_dir/added_file']" exit_code: 1

[144/1584] webkitpy.common.checkout.scm.scm_unittest.SVNTest.test_delete_recursively_or_not erred:
  Traceback (most recent call last):
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 842, in test_delete_recursively_or_not
      self._shared_test_delete_recursively_or_not()
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 481, in _shared_test_delete_recursively_or_not
      self.scm.add("added_dir/added_file")
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 134, in add
      self.add_list([path], return_exit_code)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 187, in add_list
      return self._run_svn(["add"] + paths, return_exit_code=return_exit_code)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 137, in _run_svn
      return self.run([self.executable_name] + args, **kwargs)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 78, in run
      decode_output=decode_output)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 432, in run_command
      (error_handler or self.default_error_handler)(script_error)
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 350, in default_error_handler
      raise error
  ScriptError: Failed to run "['svn', 'add', 'added_dir/added_file']" exit_code: 1

[495/1584] webkitpy.common.checkout.scm.scm_unittest.SVNTest.test_svn_lock failed:
  Traceback (most recent call last):
    File "/Users/glenn/work/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 897, in test_svn_lock
      self.assertRaises(ScriptError, run_command, ['svn', 'update'])
  AssertionError: ScriptError not raised

Ran 1584 tests in 39.856s
FAILED (failures=1, errors=3)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.