[Webkit-unassigned] [Bug 112327] [WK2] Reorganize animation starting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112327


Nandor Huszka <hnandor at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196299|0                           |1
        is obsolete|                            |




--- Comment #9 from Nandor Huszka <hnandor at inf.u-szeged.hu>  2013-04-10 02:53:57 PST ---
Created an attachment (id=197232)
 --> (https://bugs.webkit.org/attachment.cgi?id=197232&action=review)
WIP patch v2 - Approach: animations are started by FrameView

(In reply to comment #8)
> Great. You need to make sure the lists are not linking to dead RenderObjects, so remove them when RenderObjects die. Second you need to remove the all the code starting animations in BitmapImage to be able to test if this really does start them correctly.

Code is refactored and a newer patch is uploaded that fixes these things.
Do you think it is good idea to rename Image's startAnimation to continueAnimation? In my opinion this name is more expressive considering that the method does (and this way we could check where are remaining startAnimation calls that should be removed from other ports because of build fails). As I have browsed the source, I found comments that often refer to draw that it starts animation. These comments also should be rewrited, or removed in the future, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.