[Webkit-unassigned] [Bug 113853] [Qt] Add API in QWebSettings for setting the CSS media type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 10 02:49:21 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113853





--- Comment #20 from Jose Lejin PJ <jose.lejin at gmail.com>  2013-04-10 02:47:35 PST ---
(In reply to comment #19)
> (From update of attachment 197145 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197145&action=review
> 
> A few minor issues:
> 
> > Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1571
> > +    String type;
> > +    if (m_webFrame && m_webFrame->pageAdapter && m_webFrame->pageAdapter->settings)
> > +        type = m_webFrame->pageAdapter->settings->cssMediaType();
> > +
> > +    return type;
> 
> To follow a bit more the style in the rest of the file:
> 
> if (...)
>     return ...->cssMediaType();
> return String();
> 

When I uploaded first patch style checker showed error on multiple return with webkit-patch upload script. I will correct this.

> > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:3296
> > +    page = new TestPage();
> 
> Try to use the existing m_page member like other tests do, you should be able to use the same page for all chunks.
> If that helps, you can separate the global and per-page setting in two different tests.
> 
> > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:3298
> > +    QTest::qWait(500);
> 
> QVERIFY(::waitForSignal(m_view, SIGNAL(loadFinished(bool))));

I will update test cases as per comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list