[Webkit-unassigned] [Bug 113680] [css3-text] Parsing -webkit-hanging value for text-indent from css3-text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113680





--- Comment #4 from Andreas Kling <akling at apple.com>  2013-04-09 02:44:06 PST ---
(From update of attachment 196096)
View in context: https://bugs.webkit.org/attachment.cgi?id=196096&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2197
> +            // If CSS3_TEXT is disabled or text-indent has only one value(<length> | <perceantage>),
> +            // getPropertyCSSValue() returns CSSValue.

perceantage -> percentage

> Source/WebCore/css/StyleBuilder.cpp:2049
> +        TextIndentLine eachLineValue = TextIndentFirstLine;
> +        TextIndentType hangingValue = TextIndentNormal;

These are badly named, as they refer to one of two possible values in both cases.
I'd suggest something like:

TextIndentLine textIndentLineValue = RenderStyle::initialTextIndentLine();
TextIndentType textIndentTypeValue = RenderStyle::initialTextIndentType();

That way you also avoid repeating the initial values.

> Source/WebCore/rendering/style/StyleRareInheritedData.h:105
> +    unsigned m_textIndentType : 1; // TextIndentHanging

TextIndentHanging -> TextIndentType

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.