[Webkit-unassigned] [Bug 104807] Adds support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104807





--- Comment #23 from Vahag <vaag at ispras.ru>  2013-04-08 14:54:36 PST ---
(In reply to comment #22)
> (From update of attachment 196957 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196957&action=review
> 
> LGTM except for those minor fixes.
> 
> > Source/JavaScriptCore/dfg/DFGAbstractState.cpp:865
> > +        node->setCanExit(true);
> 
> Not needed.
> 
> > Source/JavaScriptCore/dfg/DFGAbstractState.cpp:866
> > +        forNode(node->child1()).filter(SpecInt32);
> 
> Not needed.
> 
> > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:352
> > +            setUseKindAndUnboxIfProfitable<Int32Use>(node->child1());
It will fail on SpeculateStrictInt32Operand property(this, node->child1()); without this.

> 
> The reason why you don't need the filter() and setCanExit() in AbstractState is that AbstractState::executeEdges() takes care of this based on Int32Use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.