[Webkit-unassigned] [Bug 113168] LayoutTests/fast/js/large-expressions.html crashes on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113168





--- Comment #18 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-04-08 01:44:28 PST ---
(From update of attachment 196832)
View in context: https://bugs.webkit.org/attachment.cgi?id=196832&action=review

Looks good. I however only meant we should subtract guardSize from stackSize for glibc and android. We should still support guardsize for the other cases. It just needs to be added to both m_bound and m_origin.

> Source/WTF/wtf/StackBounds.cpp:153
> +#ifdef __GLIBC__
> +#if __GLIBC__ == 2 && __GLIBC_MINOR__ <= 15

Combine into one line.

> Source/WTF/wtf/StackBounds.cpp:160
> +#if USE(GUARD_SIZE)

I think we should try make the patch general and support guardsize everywhere. It just only needs to be subtracted from stack_size on glibc (and android).

> Source/WTF/wtf/StackBounds.cpp:168
> +    stackBase = reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(stackBase) + guardSize);

use static_cast<char*> so you only need one cast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.