[Webkit-unassigned] [Bug 114146] [BlackBerry] Replace getRect() with boundingBox()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 01:02:57 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114146





--- Comment #5 from Alberto Garcia <agarcia at igalia.com>  2013-04-08 01:01:11 PST ---
(In reply to comment #4)
> > > Why do you need the IntRect()?
> >
> > Node::boundingBox() returns LayoutRect.
>
> I think there's an explicit constructor for that

Exactly, _explicit_, that's why there's no implicit conversion here:

Source/WebKit/blackberry/Api/WebPage.cpp:2611:62: error: no matching function for call to 'WebCore::FrameView::contentsToWindow(WebCore::LayoutRect)'
Source/WebKit/blackberry/Api/WebPage.cpp:2611:62: note: candidates are:
Source/WebCore/platform/ScrollView.h:231:14: note: WebCore::IntPoint WebCore::ScrollView::contentsToWindow(const WebCore::IntPoint&) const
Source/WebCore/platform/ScrollView.h:231:14: note:   no known conversion for argument 1 from 'WebCore::LayoutRect' to 'const WebCore::IntPoint&'
Source/WebCore/platform/ScrollView.h:233:13: note: WebCore::IntRect WebCore::ScrollView::contentsToWindow(const WebCore::IntRect&) const
Source/WebCore/platform/ScrollView.h:233:13: note:   no known conversion for argument 1 from 'WebCore::LayoutRect' to 'const WebCore::IntRect&'

> note that getRect() also returned a LayoutRect.

Well, the code was not compiling before either, but I guess it doesn't
make sense to split this change in two :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list