[Webkit-unassigned] [Bug 113957] [BlackBerry] Adjust fatfinger result priority.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113957





--- Comment #6 from Antonio Gomes <tonikitoo at webkit.org>  2013-04-07 09:16:19 PST ---
(From update of attachment 196520)
View in context: https://bugs.webkit.org/attachment.cgi?id=196520&action=review

> Source/WebKit/blackberry/ChangeLog:13
> +
> +        RIM PR 224781
> +        Internally Reviewed by Genevieve Mak.
> +
> +        Change fatfigner algorithm, return the clickable element rather than
> +        its parent anchor. Modify taphighlight and context menu node selection
> +        accordingly.

It should really mention what it fixes in real world.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:166
> +    const HitTestResult& hitResult = m_webPage->hitTestResult(m_contentPos);

Do you still have phases in FatFinger? The 'cached' results, was to avoid hit testing again, and saving up to .3s for some websites.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:171
> +    Element* elementUnderPoint = static_cast<Element*>(node);

there is a toElement helper

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.