[Webkit-unassigned] [Bug 114101] Change requisite hardware checks for enabling multisample framebuffers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114101





--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2013-04-06 23:10:28 PST ---
(From update of attachment 196754)
View in context: https://bugs.webkit.org/attachment.cgi?id=196754&action=review

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:95
> -    if (m_isNVIDIA || (m_isAMD && systemSupportsMultisampling))
> -        m_maySupportMultisampling = true;
> +    if (!(m_isNVIDIA || m_isIntel || (m_isAMD && systemSupportsMultisampling)))
> +        m_maySupportMultisampling = false;

It looks like the previous code would never put m_maySupportMultisampling = false.

What about leaving m_maySupportMultisampling uninitialized then?:
    m_maySupportMultisampling = m_isNVIDIA || m_isIntel || (m_isAMD && systemSupportsMultisampling);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.