[Webkit-unassigned] [Bug 13709] Table border doesn't show up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13709





--- Comment #45 from Antti Koivisto <koivisto at iki.fi>  2013-04-05 10:15:25 PST ---
(From update of attachment 196646)
View in context: https://bugs.webkit.org/attachment.cgi?id=196646&action=review

> Source/WebCore/css/StyleBuilder.cpp:584
> -        // note: CSSPropertyLetter/WordSpacing right now sets to zero if it's not a primitive value for some reason...
> -        if (!value->isPrimitiveValue())
> -            return;
> -
>          CSSPrimitiveValue* primitiveValue = static_cast<CSSPrimitiveValue*>(value);

Why is it ok to remove this test? Does something guarantee the value is primitive?

> Source/WebCore/css/StyleBuilder.cpp:618
> +enum ComputeLengthNormal {NormalDisabled = 0, NormalEnabled};
> +enum ComputeLengthSVGZoom {SVGZoomDisabled = 0, SVGZoomEnabled};

I don't think these are used anywhere anymore. You should remove them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.