[Webkit-unassigned] [Bug 85066] [GTK] TestWebKitAPI/WebKit2/TestMouseMoveAfterCrash is flaky

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85066





--- Comment #3 from Lauro Moura Maranhao Neto <lauro.neto at openbossa.org>  2013-04-05 07:50:44 PST ---
Created an attachment (id=196632)
 --> (https://bugs.webkit.org/attachment.cgi?id=196632&action=review)
Patch for WorkQueue and ProcessLauncher

Fixes for "bad file descriptor/socket operation on non-socket descriptor" crashes in WorkQueueGtk.cpp and ProcessLauncher.cpp. Maybe they should go on a separate bug.

>From the commit message:

    - Avoid calling connectionDidClose() twice.

    From g_source_create_source:

    "It is meaningless to specify G_IO_ERR or G_IO_HUP in condition; these
    conditions will always be reported output if they are true."

    As readyReadHandler() will be called anyway for G_IO_HUP e G_IO_ERR, let
    it in charge of calling connectionDidClose instead of adding another
    event source, just like EFL and Qt does.

    - Check the status of m_cancellable().

    EventSource::cancel() cancels m_cancellable, which triggers this
    source with the current condition. A check for the cancellable status
    is needed to check whether it was cancelled or not.

    - Do not close the child socket when it's terminated.

    This action is delegated to Connection::platformInvalidate.
    Closing it here can raise race conditions when polling the sockets
    from the WorkQueue mainloop.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.