[Webkit-unassigned] [Bug 114029] Incorrect evaluation of resolution media queries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 5 06:34:47 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114029





--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2013-04-05 06:33:01 PST ---
Attachment 196626 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/media/mq-resolution.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:303:  device_pixel_ratioMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list