[Webkit-unassigned] [Bug 113913] [SOUP] Remove unnecessary explicit keyword in SocketStreamError.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113913


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




--- Comment #4 from Xan Lopez <xan.lopez at gmail.com>  2013-04-05 01:46:15 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 196428 [details] [details])
> > Why is the keyword not needed in this case? Do we want to use it in implicit conversions?
> 
> It seems that c++11 supports for explicit keyword on multi-arg constructor.
> But normally, we use the C++ keyword explicit for constructors with one argument.
> So, I have just removed it like other ports.

It seems the ctor had originally just one argument, but then another was added in r102339 and the explicit keyword was not removed. If you say C++ before 11 does not support explicit multi-argument ctors then I guess it makse sense to remove it, but on the other hand WebKit is slowly moving to c++11 and this seems to be harmless. So no strong opinion here.

Martin reviewed the original commit, so maybe he has an opinion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.