[Webkit-unassigned] [Bug 113168] LayoutTests/fast/js/large-expressions.html crashes on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113168


Allan Sandfeld Jensen <allan.jensen at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194976|review?                     |review-
               Flag|                            |




--- Comment #13 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-04-04 06:49:12 PST ---
(From update of attachment 194976)
View in context: https://bugs.webkit.org/attachment.cgi?id=194976&action=review

> Source/WTF/wtf/StackBounds.cpp:152
> +    // FIXME: Not sure if the libc of other unix is using the same implementation as linux does.If anyone does,please remove the OS(LINUX) macro.
> +#if OS(LINUX)

pthread_attr_getguardsize is a generic POSIX call, please enable it for all UNIX. Whether this code is correct or not only depends on whether the stack grows up or down, but we seem to only handle stacks growing dow here.

> Source/WTF/wtf/StackBounds.cpp:161
> +    stackBase = reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(stackBase) + guardSize);
> +    stackSize -= guardSize;

GuardSize does not affect stackSize. This hack is only necessary because of how m_origin is set lower down. Remove it and just set
m_bound as stackBase + guardSize.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.