[Webkit-unassigned] [Bug 113842] [Qt] WebSocket errors should be logged to console
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 4 02:35:09 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113842
--- Comment #10 from Seokju Kwon <seokju.kwon at gmail.com> 2013-04-04 02:33:21 PST ---
(In reply to comment #8)
> (From update of attachment 196436 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196436&action=review
>
> A few more nitpicks.
>
> > Source/WebCore/platform/network/qt/SocketStreamError.h:46
> > + SocketStreamError(int errorCode, QString description)
>
> const QString&
>
> > Source/WebCore/platform/network/qt/SocketStreamError.h:47
> > + : SocketStreamErrorBase(errorCode, String(), String(description))
>
> The String(const QString&) consturctor isn't explicit, so you can pass the description parameter straight.
>
> > Source/WebCore/platform/network/qt/SocketStreamHandleQt.cpp:62
> > - unsigned int port = url.hasPort() ? url.port() : (isSecure ? 443 : 80);
> > + unsigned port = url.hasPort() ? url.port() : (isSecure ? 443 : 80);
>
> We usually don't do cleanups like this unless they have a considerable value to avoid poluting the line history (git blame).
>
> > LayoutTests/platform/qt/http/tests/inspector/console-websocket-error-expected.txt:5
> > +CONSOLE MESSAGE: WebSocket network error: The host name did not match any of the valid hosts for this certificate
>
> Looks much better, thanks :)
Thanks. All done :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list