[Webkit-unassigned] [Bug 113641] [EFL] --minimal build fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113641





--- Comment #17 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-04-02 22:13:53 PST ---
(From update of attachment 196012)
View in context: https://bugs.webkit.org/attachment.cgi?id=196012&action=review

> Source/WebCore/editing/FrameSelection.h:333
>  #if !(PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(CHROMIUM) || PLATFORM(EFL))
> +#if HAVE(ACCESSIBILITY)

Are you sure that HAVE(ACCESSIBILITY) defined for all these ports? Also do these ports all allow turning ACCESSIBILITY off ? Not all configuration options are valid for all ports.

Shouldn't this be the following instead:
#if !(PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(CHROMIUM) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY)))

> Source/WebCore/editing/chromium/FrameSelectionChromium.cpp:39
> +#if HAVE(ACCESSIBILITY)

This should not be necessary as this is file is not used for EFL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.