[Webkit-unassigned] [Bug 107207] [V8] Support selectively wrapping DOM accesses from certain V8 contexts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107207





--- Comment #35 from Kentaro Hara <haraken at chromium.org>  2013-04-02 18:32:05 PST ---
(From update of attachment 196263)
View in context: https://bugs.webkit.org/attachment.cgi?id=196263&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:958
> +        OwnArrayPtr<v8::Handle<v8::Value> > loggerArgs = toOwnArrayPtrArguments<v8::Handle<v8::Value> >(args);

Would you explain why you need to use OwnArrayPtr?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:976
> +    V8DOMActivityLogger* logger = V8PerContextData::from(v8::Context::GetCurrent())->activityLogger();

The patch looks OK as long as this doesn't regress performance.

Unfortunately, it regresses performance today. I hope that the GetCurrent(Isolate*) patch in V8 will resolve the performance issue. Would you measure how much it helps?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.