[Webkit-unassigned] [Bug 113826] New: RenderLayer::paintsWithFilters() is probably wrong without USE(ACCELERATED_COMPOSITING)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113826

           Summary: RenderLayer::paintsWithFilters() is probably wrong
                    without USE(ACCELERATED_COMPOSITING)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: shawnsingh at chromium.org
                CC: simon.fraser at apple.com, dino at apple.com,
                    vollick at chromium.org, hartmanng at chromium.org


RenderLayer::paintsWithFilters() -

If USE(ACCELERATED_COMPOSITING) is true, the code makes sense.  But, when USE(ACCELERATED_COMPOSITING) is false, the last return statement should probably be returning true instead.

git blame shows that the code originally existed without the #if guards, and the guards were added later in https://bugs.webkit.org/show_bug.cgi?id=84460 - it seems plausible to me that at that time (april 2012), the USE(ACCELERATED_COMPOSITING) flag was almost always on already, so no bug ever has arisen from it.

Seems like the last return value should be dependent on the value of USE(ACCELERATED_COMPOSITING):

#if USE(ACCELERATED_COMPOSITING)
    return false; // compositor will apply the filters
#else
    return true;  // filters should be handled during paint time.
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.