[Webkit-unassigned] [Bug 113522] [Qt] Enable text tracks from track elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113522





--- Comment #18 from Alexis Menard (darktears) <alexis at webkit.org>  2013-04-02 11:18:51 PST ---
(In reply to comment #17)
> (In reply to comment #12)
> 
> > > Source/WebCore/ChangeLog:10
> > > +        No new tests because they're already there. This just enables the feature.
> > 
> > Could you unskip the tests in LayoutTests/platform/qt/TestExpectations then?
> 
> As far as I can tell, they weren't being skipped. Is there something I should look at besides the TestExpectations files (I checked all of the qt and generic ones just in case). The opera ones still don't work, but those don't work on any platforms. The ones that do work are in LayoutTests/media/track (not the subdirectories).

>From my understanding Opera suite is not yet fully working for WebKit so we can let them skipped. TestExpectations is enough. 

> 
> > > Tools/qmake/mkspecs/features/features.pri:120
> > > -    ENABLE_VIDEO_TRACK=0 \
> > > +    ENABLE_VIDEO_TRACK=1 \
> > 
> > What happens when VIDEO_TRACK is enabled and HTML5 video or GStreamer isn't?
> 
> Now that you point this out, I'm confused about why video works at all in QtWebkit, since I can't figure out where VIDEO_ENABLED gets set to 1.

Tools/qmake/mkspecs/features/features.prf around line 120.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.