[Webkit-unassigned] [Bug 110717] [EFL] Consolidate defaults for feature flags
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 2 06:59:12 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=110717
--- Comment #17 from Hugo Parente Lima <hugo.lima at openbossa.org> 2013-04-02 06:57:22 PST ---
(From update of attachment 193455)
View in context: https://bugs.webkit.org/attachment.cgi?id=193455&action=review
>> Tools/Scripts/build-webkit:93
>> + my $port = "EFL";
>
> Do you anticipate making use of this local variable in the near future? Otherwise, I suggest we inline its value into the definition of $portDefine (below) since that is the only expression that references $port inside this if-block.
I plan to use this code on Nix (an out of trunk port), so would be better to use cmakeBasedPortName() function instead of the "EFL" string to turn the code more generic.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list