[Webkit-unassigned] [Bug 113522] [Qt] Enable text tracks from track elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113522


Allan Sandfeld Jensen <allan.jensen at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196000|review?                     |review-
               Flag|                            |




--- Comment #12 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-04-01 16:43:03 PST ---
(From update of attachment 196000)
View in context: https://bugs.webkit.org/attachment.cgi?id=196000&action=review

> Source/WebCore/ChangeLog:5
> +        Enable text tracks in QtWebKit.
> +
> +        [Qt] Enable text tracks from track elements

Please drop the first line and let the bug title be the commit subject.

> Source/WebCore/ChangeLog:10
> +        No new tests because they're already there. This just enables the feature.

Could you unskip the tests in LayoutTests/platform/qt/TestExpectations then?

> Tools/qmake/mkspecs/features/features.pri:120
> -    ENABLE_VIDEO_TRACK=0 \
> +    ENABLE_VIDEO_TRACK=1 \

What happens when VIDEO_TRACK is enabled and HTML5 video or GStreamer isn't?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.