[Webkit-unassigned] [Bug 113318] [GTK][AC] Support preserves3D css property for clutter ac backend.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113318





--- Comment #7 from Joone Hur <joone at webkit.org>  2013-04-01 12:58:22 PST ---
(From update of attachment 195839)
View in context: https://bugs.webkit.org/attachment.cgi?id=195839&action=review

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:712
>> +        graphicsLayerActorSetFlattening(childLayer, !(preserves3D() || currentChild->preserves3D()));
> 
> Not sure I understand this comment. What this is doing is telling the child to flatten if neither the "this" layer nor the currentChild has preserve3D set. If that is correct behaviour, then I think we can do away with the comment. The comment implies the layer and its children should be flattened if the "this" layer has preserves3D set to false.

All elements transform-style property has false value by default, so preserve3D() usually returns false. I think we can change the comment as follws:
"If the preserve3D() of this layer returns true, its children should not be flattened"

By the way, do we really need to check currentChild->preserves3D()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.