[Webkit-unassigned] [Bug 108897] [Cairo] Canvas-shadow behavior is not being as expected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108897


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195942|review?                     |review-
               Flag|                            |




--- Comment #22 from Benjamin Poulain <benjamin at webkit.org>  2013-04-01 12:41:45 PST ---
(From update of attachment 195942)
View in context: https://bugs.webkit.org/attachment.cgi?id=195942&action=review

No clue about the patch's correctness, but the ChangeLog is not good enough.

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

You should remove this line; No ChangeLog with "OOPS" should land.

> Source/WebCore/ChangeLog:11
> +        In PlatformContextCairo::drawSurfaceToContext(), 
> +        extend mode for the pattern should be CAIRO_EXTEND_NONE

It is not enough explaining what you did, you have to explain why you are doing the change:

You need to explain why the code was wrong, what errors it was causing, and why the new code is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.