[Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 06:23:35 PDT 2013


Yoav Weiss <yoav at yoav.ws> changed:

           What    |Removed                     |Added
 Attachment #181465|0                           |1
        is obsolete|                            |

--- Comment #8 from Yoav Weiss <yoav at yoav.ws>  2013-04-01 06:21:46 PST ---
Created an attachment (id=195963)
 --> (https://bugs.webkit.org/attachment.cgi?id=195963&action=review)
Preload external stylesheet according to their media attribute

Here's my new attempt at resolving this issue.
The patch is based on the new multi-threaded PreloadScanner architecture.
The PreloadScanner now passed the media attribute string to the ResourcePreloader, and the ResourcePreloader evaluates the MQs using the document's existing RenderStyle and Frame.
I've moved the MQ resolution bits to HTMLResourcePreloader.cpp, so I've removed this dependency from the HTMLPreloadScanner.cpp and added it to HTMLResourcePreloader.cpp. I also added RenderObject dependency to HTMLResourcePreloader.cpp as well. I hope that's OK.
I've tested it locally and it seems to work fine, but I didn't yet write proper Layout tests.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list